-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seeed XIAO RP2040 board #524
Conversation
It's kinda awkward that you have to go to the wiki page and then look at the schematics to work out what RP2040 pin numbers they've actually used for different things! 😕 But AFAICT the numbers you've used here look correct 👍 |
Waiting for my board to arrive so I can test the macros for that GD SPI flash chip. |
it sounds like this is not ready to merge, so i have converted it to a draft |
// All boards have B1 RP2040 | ||
#ifndef PICO_FLOAT_SUPPORT_ROM_V1 | ||
#define PICO_FLOAT_SUPPORT_ROM_V1 0 | ||
#endif | ||
|
||
#ifndef PICO_DOUBLE_SUPPORT_ROM_V1 | ||
#define PICO_DOUBLE_SUPPORT_ROM_V1 0 | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a similar change to c682e3c please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lurch, updated
|
||
//------------- I2C -------------// | ||
#ifndef PICO_DEFAULT_I2C | ||
#define PICO_DEFAULT_I2C 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using I2C on pins GP6 and GP7, then that's I2C1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lurch, updated. Pins now match sparkfun_thingplus.h who is also using GP6/GP7 for I2C1
Matches sparkfun_thingplus.h also using GP6/GP7
Thanks for the updates. Did you manage to make any progress with testing the "GD SPI flash chip" ? |
I still haven't received a board from Seeed yet, so I can't test. The adafruit_feather_rp2040.h board also uses (larger) GD flash and they use the same |
|
@mcauser |
@mcauser see #691 - I'll leave it up to you and @ryanplusplus to work out what you want to do 🙂 |
Sounds like #691 supersedes this PR, so I guess this PR should be closed? 🤷 |
closing - reopen if need be |
New Seeed board:
https://www.seeedstudio.com/XIAO-RP2040-v1-0-p-5026.html
Not sure about this line:
It comes with a GD25Q16CEIG - 2MB SPI NAND Flash.
Not sure if that is compatible with W25Qxx used on other boards, and if it should be changed to: