Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seeed XIAO RP2040 board #524

Closed
wants to merge 3 commits into from

Conversation

mcauser
Copy link
Contributor

@mcauser mcauser commented Jul 23, 2021

New Seeed board:
https://www.seeedstudio.com/XIAO-RP2040-v1-0-p-5026.html

Not sure about this line:

#define PICO_BOOT_STAGE2_CHOOSE_GENERIC_03H 1

It comes with a GD25Q16CEIG - 2MB SPI NAND Flash.

Not sure if that is compatible with W25Qxx used on other boards, and if it should be changed to:

#define PICO_BOOT_STAGE2_CHOOSE_W25Q080 1

@mcauser mcauser marked this pull request as ready for review July 23, 2021 16:37
@lurch
Copy link
Contributor

lurch commented Jul 24, 2021

It's kinda awkward that you have to go to the wiki page and then look at the schematics to work out what RP2040 pin numbers they've actually used for different things! 😕 But AFAICT the numbers you've used here look correct 👍

@mcauser
Copy link
Contributor Author

mcauser commented Jul 26, 2021

Waiting for my board to arrive so I can test the macros for that GD SPI flash chip.

@kilograham kilograham changed the base branch from master to develop August 11, 2021 14:20
@kilograham kilograham marked this pull request as draft August 11, 2021 14:20
@kilograham
Copy link
Contributor

it sounds like this is not ready to merge, so i have converted it to a draft

Comment on lines 86 to 93
// All boards have B1 RP2040
#ifndef PICO_FLOAT_SUPPORT_ROM_V1
#define PICO_FLOAT_SUPPORT_ROM_V1 0
#endif

#ifndef PICO_DOUBLE_SUPPORT_ROM_V1
#define PICO_DOUBLE_SUPPORT_ROM_V1 0
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a similar change to c682e3c please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lurch, updated


//------------- I2C -------------//
#ifndef PICO_DEFAULT_I2C
#define PICO_DEFAULT_I2C 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using I2C on pins GP6 and GP7, then that's I2C1 ?

Copy link
Contributor Author

@mcauser mcauser Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lurch, updated. Pins now match sparkfun_thingplus.h who is also using GP6/GP7 for I2C1

@lurch
Copy link
Contributor

lurch commented Oct 27, 2021

Thanks for the updates. Did you manage to make any progress with testing the "GD SPI flash chip" ?

@mcauser
Copy link
Contributor Author

mcauser commented Oct 27, 2021

I still haven't received a board from Seeed yet, so I can't test.

The adafruit_feather_rp2040.h board also uses (larger) GD flash and they use the same GENERIC_03H config.
Should work but would be better to test it on hardware before merging.

@prplz
Copy link

prplz commented Dec 4, 2021

GENERIC_03H and W25Q080 are both working for me on the seeed board.
The flash is actually puya P25Q16H.
Related: adafruit/circuitpython#5519

@prplz
Copy link

prplz commented Dec 9, 2021

@mcauser PICO_DEFAULT_LED_PIN should be 25 (the schematic is outdated or something) and you should set PICO_DEFAULT_LED_PIN_INVERTED to 1

@lurch
Copy link
Contributor

lurch commented Jan 1, 2022

@mcauser see #691 - I'll leave it up to you and @ryanplusplus to work out what you want to do 🙂

@lurch
Copy link
Contributor

lurch commented Mar 22, 2022

Sounds like #691 supersedes this PR, so I guess this PR should be closed? 🤷

@kilograham
Copy link
Contributor

closing - reopen if need be

@kilograham kilograham closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants