Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving JS to Simplified Method in datatable #1832

Merged
merged 9 commits into from
Aug 10, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 10, 2024

Several major changes to the blades/js code

  1. Migrate all core methods into a single function
  2. Migrate the x-data into the datatable top level x-data rather than child nodes/wrapper
  3. Add the following as blade attributes into the wrapper, and make child blades aware, mitigating repetitive calls.
  • primaryKey
  • isTailwind
  • isBootstrap
  • isBootstrap4
  • isBootstrap5

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (40485a0) to head (56e69da).
Report is 44 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1832      +/-   ##
=================================================
+ Coverage          87.14%   88.57%   +1.43%     
- Complexity          1495     1622     +127     
=================================================
  Files                139      150      +11     
  Lines               3484     3765     +281     
=================================================
+ Hits                3036     3335     +299     
+ Misses               448      430      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit be9fb44 into rappasoft:development Aug 10, 2024
7 checks passed
lrljoe added a commit that referenced this pull request Aug 10, 2024
## [v3.4.4] - 2024-08-10
### New Features
- Boolean/Toggle Filter by @lrljoe in #1830

### Bug Fixes
- Merge Column Attributes Back in if Sortable by @lrljoe in #1833

### Tweaks
- Moving JS to Simplified Method in datatable  by @lrljoe in #1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant