-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean/Toggle Filter #1830
Merged
Merged
Boolean/Toggle Filter #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1830 +/- ##
=================================================
+ Coverage 87.14% 88.60% +1.46%
- Complexity 1495 1610 +115
=================================================
Files 139 150 +11
Lines 3484 3747 +263
=================================================
+ Hits 3036 3320 +284
+ Misses 448 427 -21 ☔ View full report in Codecov by Sentry. |
lrljoe
added a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
Beta
This is currently in beta, and will only work with Tailwind.
Details
The BooleanFilter is designed so that you can toggle a more complex query/filter, as opposed to being a yes/no type of filter (which is what the SelectFilter is perfect for)
For example, your filter may look like this, toggling the filter from true to false would apply/not apply a more complex query to the query.
Many of the standard methods are available, for example
All Submissions:
New Feature Submissions:
Changes to Core Features: