Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old $listeners approach #1821

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 4, 2024

This removes the old $listeners approach for events, and uses the Livewire v3 On Attribute instead.

refreshDatatable is bound to boot() of the DataTableComponent, reflecting the original behaviour

The original methods are present, although not used.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (40485a0) to head (dcbb8f1).
Report is 31 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1821      +/-   ##
=================================================
+ Coverage          87.14%   88.45%   +1.31%     
- Complexity          1495     1598     +103     
=================================================
  Files                139      149      +10     
  Lines               3484     3725     +241     
=================================================
+ Hits                3036     3295     +259     
+ Misses               448      430      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 8b3b223 into rappasoft:development Aug 4, 2024
@lrljoe lrljoe mentioned this pull request Aug 4, 2024
9 tasks
lrljoe added a commit that referenced this pull request Aug 4, 2024
## [v3.4.2] - 2024-08-04
### New Features
- Additional Events & Customisable Behaviour by @lrljoe in #1820

### Bug Fixes
- Typehinting to allow events to be used to update Multi-Value Filters by @lrljoe in #1822

### Tweaks
- Add missing ReturnTypes by @lrljoe in #1823
- Removing old $listeners approach, now using the Livewire v3 On attribute by @lrljoe in #1821


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant