Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Events & Customisable Behaviour #1820

Merged
merged 22 commits into from
Aug 4, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 4, 2024

This introduces two new Events that are dispatched by the Table

  • When a Filter is Applied
  • When a Search is Applied
    This adds to the current Event
  • When Column Select is changed

This also adds in behaviour to enable/disable each of these Events.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe self-assigned this Aug 4, 2024
@lrljoe lrljoe marked this pull request as draft August 4, 2024 05:56
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (40485a0) to head (a6ec306).
Report is 30 commits behind head on development.

Files Patch % Lines
src/Traits/Configuration/EventConfiguration.php 77.14% 8 Missing ⚠️
src/Traits/Helpers/EventHelpers.php 66.66% 4 Missing ⚠️
src/Traits/WithColumnSelect.php 0.00% 2 Missing ⚠️
src/Events/LaravelLivewireTablesEvent.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1820      +/-   ##
=================================================
+ Coverage          87.14%   88.10%   +0.96%     
- Complexity          1495     1598     +103     
=================================================
  Files                139      149      +10     
  Lines               3484     3725     +241     
=================================================
+ Hits                3036     3282     +246     
+ Misses               448      443       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe marked this pull request as ready for review August 4, 2024 06:31
@lrljoe lrljoe merged commit 664e119 into rappasoft:development Aug 4, 2024
@lrljoe lrljoe mentioned this pull request Aug 4, 2024
9 tasks
lrljoe added a commit that referenced this pull request Aug 4, 2024
## [v3.4.2] - 2024-08-04
### New Features
- Additional Events & Customisable Behaviour by @lrljoe in #1820

### Bug Fixes
- Typehinting to allow events to be used to update Multi-Value Filters by @lrljoe in #1822

### Tweaks
- Add missing ReturnTypes by @lrljoe in #1823
- Removing old $listeners approach, now using the Livewire v3 On attribute by @lrljoe in #1821


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant