Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message context #520

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 11, 2024

Description

Resolves #514

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 11, 2024
@vyasr vyasr self-assigned this Jan 11, 2024
@vyasr vyasr requested a review from a team as a code owner January 11, 2024 19:22
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I wonder if there would be a way to test this to make sure future macros don't have this problem...

@vyasr
Copy link
Contributor Author

vyasr commented Jan 11, 2024

That's a good question. I'm not sure if there's an easy, semantically-aware solution. The simplest purely textual solution I could think of would be writing a pre-commit hook that just counts instances of the insertion and pop_back. There's probably an ideal middle ground that we could find.

@robertmaynard
Copy link
Contributor

That's a good question. I'm not sure if there's an easy, semantically-aware solution. The simplest purely textual solution I could think of would be writing a pre-commit hook that just counts instances of the insertion and pop_back. There's probably an ideal middle ground that we could find.

I can't think of a nice way that doesn't include parsing the source code.

@vyasr
Copy link
Contributor Author

vyasr commented Jan 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit f38531d into rapidsai:branch-24.02 Jan 11, 2024
16 checks passed
@vyasr vyasr deleted the fix/cython_message branch January 11, 2024 20:24
PointKernel pushed a commit to PointKernel/rapids-cmake that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cython_init() does not clear its modification to CMAKE_MESSAGE_CONTEXT
3 participants