Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] rapids_cython_init() does not clear its modification to CMAKE_MESSAGE_CONTEXT #514

Closed
Jacobfaib opened this issue Dec 27, 2023 · 1 comment · Fixed by #520
Closed

[BUG] rapids_cython_init() does not clear its modification to CMAKE_MESSAGE_CONTEXT #514

Jacobfaib opened this issue Dec 27, 2023 · 1 comment · Fixed by #520
Assignees
@vyasr
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@Jacobfaib
Copy link
Contributor

There is no matching list(POP_BACK CMAKE_MESSAGE_CONTEXT) for https://github.com/rapidsai/rapids-cmake/blob/branch-24.02/rapids-cmake/cython/init.cmake#L40. Since rapids_cython_init() is a macro, this doesn't reset on scope-exit.
@Jacobfaib Jacobfaib added ? - Needs Triage Need team to review and classify bug Something isn't working labels Dec 27, 2023
@robertmaynard
Copy link
Contributor

@vyasr

@vyasr vyasr mentioned this issue Jan 11, 2024
Merged
7 tasks
@rapids-bot rapids-bot bot closed this as completed in #520 Jan 11, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 11, 2024
@vyasr
Fix message context (#520)
f38531d 
Resolves #514

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #520
PointKernel pushed a commit to PointKernel/rapids-cmake that referenced this issue Jan 23, 2024
@vyasr @PointKernel
Fix message context (rapidsai#520)
9fa5f15 
Resolves rapidsai#514

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: rapidsai#520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasr vyasr

Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix message context vyasr/rapids-cmake
3 participants
@robertmaynard @vyasr @Jacobfaib