Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cuda_patch_toolkit: Better handle non-standard toolkits #324

Merged
merged 3 commits into from
Dec 12, 2022
Merged

rapids_cuda_patch_toolkit: Better handle non-standard toolkits #324

merged 3 commits into from
Dec 12, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

Previously we presumed that cublas, cusparse, and cusolver would always be found and offer both static and shared versions. Now we only setup these rules if the correct targets exist.

Fixes #321

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard
rapids_cuda_patch_toolkit: Better handle non-standard toolkits
3520110 
Previously we presumed that `cublas`, `cusparse`, and `cusolver`
would always be found and offer both static and shared versions.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Dec 7, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner December 7, 2022 19:01
@robertmaynard @bdice
Update rapids-cmake/cuda/patch_toolkit.cmake
39376be 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@robertmaynard robertmaynard requested a review from bdice December 8, 2022 18:04
@robertmaynard robertmaynard force-pushed the rapids_cuda_patch_toolkit_more_robust branch from 43bc98e to 1a41962 Compare December 8, 2022 18:26
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ce6d4b4 into rapidsai:branch-23.02 Dec 12, 2022
@robertmaynard robertmaynard deleted the rapids_cuda_patch_toolkit_more_robust branch December 12, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cuda_patch_toolkit 'fixes' should be version guarded
2 participants
@robertmaynard @bdice