Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] rapids_cuda_patch_toolkit 'fixes' should be version guarded #321

Closed
robertmaynard opened this issue Dec 1, 2022 · 0 comments · Fixed by #324
Closed

[BUG] rapids_cuda_patch_toolkit 'fixes' should be version guarded #321

robertmaynard opened this issue Dec 1, 2022 · 0 comments · Fixed by #324
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working

Comments

@robertmaynard
Copy link
Contributor

Describe the bug
The fixes in rapids_cuda_patch_toolkit aren't version guarded so it potentially could cause problems if target names change

Expected behavior
rapids-cmake only applies the fixes to versions of FindCUDAToolkit as needed
@robertmaynard robertmaynard added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 1, 2022
@robertmaynard robertmaynard added 0 - Backlog In queue waiting for assignment and removed ? - Needs Triage Need team to review and classify labels Dec 1, 2022
@robertmaynard robertmaynard mentioned this issue Dec 7, 2022
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #324 Dec 12, 2022
rapids-bot bot pushed a commit that referenced this issue Dec 12, 2022
@robertmaynard
rapids_cuda_patch_toolkit: Better handle non-standard toolkits (#324)
ce6d4b4 
Previously we presumed that `cublas`, `cusparse`, and `cusolver` would always be found and offer both static and shared versions. Now we only setup these rules if the correct targets exist.

Fixes #321

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #324
@rapids-bot rapids-bot bot moved this to Done in rapids-cmake Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working
Projects
rapids-cmake
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rapids_cuda_patch_toolkit: Better handle non-standard toolkits robertmaynard/rapids-cmake
1 participant
@robertmaynard