Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build_categorical_column in favor of CategoricalColumn constructor #16617

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Remove build_categorical_column in favor of CategoricalColumn constructor #16617

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7b37587
Remove build_categorical_column in favor of CategoricalColumn constru…
mroeschke Aug 19, 2024
87e51de
Remove import, better alignment
mroeschke Aug 19, 2024
5b036f9
Merge remote-tracking branch 'upstream/branch-24.10' into rm/build_ca…
mroeschke Aug 20, 2024
85c90bd
Make sure some codes are unsigned ints
mroeschke Aug 20, 2024
cccf149
Merge remote-tracking branch 'upstream/branch-24.10' into rm/build_ca…
mroeschke Aug 21, 2024
d07734f
Fix test failures
mroeschke Aug 21, 2024
8cd901d
Merge branch 'branch-24.10' into rm/build_categorical_constructor
mroeschke Aug 27, 2024
d9bd384
Adjust some typing
mroeschke Aug 27, 2024
00beb76
Merge branch 'branch-24.10' into rm/build_categorical_constructor
galipremsagar Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions python/cudf/cudf/core/_internals/where.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,6 @@ def _check_and_cast_columns_with_other(
return _normalize_categorical(source_col.astype(common_dtype), other)


def _make_categorical_like(result, column):
if isinstance(column, cudf.core.column.CategoricalColumn):
result = cudf.core.column.build_categorical_column(
categories=column.categories,
codes=result,
mask=result.base_mask,
size=result.size,
offset=result.offset,
ordered=column.ordered,
)
return result


def _can_cast(from_dtype, to_dtype):
"""
Utility function to determine if we can cast
Expand Down
1 change: 0 additions & 1 deletion python/cudf/cudf/core/column/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from cudf.core.column.column import (
ColumnBase,
as_column,
build_categorical_column,
build_column,
column_empty,
column_empty_like,
Expand Down
Loading
Loading