Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build_categorical_column in favor of CategoricalColumn constructor #16617

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Remove build_categorical_column in favor of CategoricalColumn constructor #16617

merged 9 commits into from
Aug 28, 2024

Conversation

mroeschke
Copy link
Contributor

Description

build_categorical_column was largely redundant with the CategoricalColumn constructor, so in the spirit of having One Way to Do Things, replacing the former with the latter.

There is usage of build_categorical_column in cugraph that has been replaced in rapidsai/cugraph#4618

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 20, 2024
@mroeschke mroeschke requested review from a team as code owners August 20, 2024 21:39
rjzamora
rjzamora approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dask-related changes look okay to me. That said, I'm no expert on proper cudf.core.column.CategoricalColumn usage :)

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit dba6c1f into rapidsai:branch-24.10 Aug 28, 2024
82 checks passed
@mroeschke mroeschke deleted the rm/build_categorical_constructor branch August 28, 2024 19:48
@hucorz hucorz mentioned this pull request Dec 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @galipremsagar @vyasr @rjzamora