Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS::Context Visibility #4335

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix TLS::Context Visibility #4335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee41b6b
Add BOTAN_PUBLIC_API to TLS::Context class
atreiber94 Sep 6, 2024
f0ecad0
Move examples target to shared build in ci;
atreiber94 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/tls/asio/asio_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct fn_signature_helper<R (D::*)(Args...)> {
/**
* A helper class to initialize and configure Botan::TLS::Stream
*/
class Context {
class BOTAN_PUBLIC_API(2, 11) Context {
public:
// statically extract the function signature type from Callbacks::tls_verify_cert_chain
// and reuse it as an std::function<> for the verify callback signature
Expand Down
4 changes: 2 additions & 2 deletions src/scripts/ci_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ def __exit__(self, exc_type, exc_value, exc_tb):
print("::endgroup::")

def build_targets(target, target_os):
if target in ['shared', 'minimized', 'bsi', 'nist']:
if target in ['shared', 'minimized', 'bsi', 'nist', 'examples']:
yield 'shared'
elif target in ['static', 'examples', 'fuzzers', 'cross-arm32-baremetal', 'emscripten']:
elif target in ['static', 'fuzzers', 'cross-arm32-baremetal', 'emscripten']:
yield 'static'
elif target_os in ['windows']:
yield 'shared'
Expand Down
Loading