Fix TLS::Context Visibility #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will catch linker visibility issues with shared builds
reneme
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
For the record: This was introduced in #3799 which introduced a convenience constructor (TLS::Context::Context(Server_Information)), which is the first method in TLS::Context that is not implemented in the header itself.
It didn't get caught because this "sane defaults" constructor is currently used only in the examples and not the unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS::Contextmissed aBOTAN_PUBLIC_APIflag which resulted in a linker error with a shared build inexamples/tls_stream_coroutine_client.cpp.This PR also builds the examples with
sharedto catch such issues.