Bump helm to v3.14.1 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0e6c75 to
964038c
Compare
adamkpickering
requested changes
Feb 26, 2024
7d811b6 to
fe4c5a5
Compare
adamkpickering
approved these changes
Feb 27, 2024
|
@vardhaman22 Any chance to get this PR merged? |
@recena |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump helm to v3.14.1 and go to 1.21
fixes an issue with helm change in v3.14.1
till helm v3.13.x engine initialization was based on config: ref and because of that the check to create engine's lookup func pass in case of nil config.
but in helm v3.14.x clientprovider is introduced and the clientProvider is not nil even if we pass nil config. ref
and then the check is also modified and now relies on the clientprovider.
So if we initialize Engine using New function with nil config it will cause this lookup function to be used even though the config is nil now. Which can cause issues while rendering templates. That's why replaced the constructor call with type initialization.
bump golangci-lint to v1.54.0