Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] remove psp related hull tests and bump helm to v3.14.1 #3495

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented Feb 21, 2024

Issue

bumping helm to latest v3.14.1 version for tests

Problem

since helm v3.14.1 uses k8s libraries 0.29.x and psps are completely removed from those libraries,

Solution

  1. psp related hull test cases are removed.
  2. coverage check is disabled since coverage will not be 100% after psp related test cases are removed.

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@vardhaman22 vardhaman22 requested review from a team as code owners February 21, 2024 13:15
@vardhaman22 vardhaman22 changed the title [v2.9] remove psp related hull tests and bump helm to v3.14.1 [WIP][v2.9] remove psp related hull tests and bump helm to v3.14.1 Feb 21, 2024
@recena
Copy link
Collaborator

recena commented Feb 21, 2024

@vardhaman22 Instead of using the convention of [WIP] in the PR title, use the GH Draft feature. In this way, reviewers will receive the notifications when the PR is ready to be reviewed.

@recena recena changed the title [WIP][v2.9] remove psp related hull tests and bump helm to v3.14.1 [v2.9] remove psp related hull tests and bump helm to v3.14.1 Feb 21, 2024
@recena recena marked this pull request as draft February 21, 2024 15:15
@adamkpickering
Copy link
Contributor

@vardhaman22 what is the status of this PR? Still WIP?

@vardhaman22
Copy link
Contributor Author

vardhaman22 commented Feb 23, 2024

@vardhaman22 what is the status of this PR? Still WIP?

@adamkpickering i faced an issue while trying to bump helm to v3.14.1 and raised a PR to fix it in hull. so we will not be able to merge this till that gets fixed. I have updated the PR description.

@vardhaman22
Copy link
Contributor Author

hi @adamkpickering @recena since I am not sure who is going to review the hull PR for the fix, it used to be eliyam but he has left the org.. not sure who is maintaining hull repo now. So I have created a PR to disable the hull tests, so that we can bump helm here for now.

@recena
Copy link
Collaborator

recena commented Feb 26, 2024

@vardhaman22

So I have created a #3516 to disable the hull tests, so that we can bump helm here for now.

Why do you need to disable the test to upgrade Helm?

@vardhaman22
Copy link
Contributor Author

@vardhaman22

So I have created a #3516 to disable the hull tests, so that we can bump helm here for now.

Why do you need to disable the test to upgrade Helm?

@recena because of the helm upgrade there is an issue in parsing templates in hull. so that needs to be fixed in hull first and then only the tests will start passing. I have explained the issue in detail in hull PR

@recena
Copy link
Collaborator

recena commented Feb 26, 2024

I assume this PR is blocked by rancher/hull#43, right?

@vardhaman22
Copy link
Contributor Author

I assume this PR is blocked by rancher/hull#43, right?

yes

@adamkpickering
Copy link
Contributor

@vardhaman22 rancher/hull#43 is merged now. That unblocks this, right?

@vardhaman22 vardhaman22 force-pushed the remove-psp-hull-tests branch from 4080e7a to 7a07219 Compare March 18, 2024 12:14
@vardhaman22
Copy link
Contributor Author

@vardhaman22 rancher/hull#43 is merged now. That unblocks this, right?

yes @adamkpickering i have updated the description of the PR and also rebased it. The CI for hull tests also passed so now it is ready for review.

@vardhaman22 vardhaman22 marked this pull request as ready for review March 18, 2024 12:26
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vardhaman22 vardhaman22 force-pushed the remove-psp-hull-tests branch from d2aa7d6 to cde989f Compare March 19, 2024 05:10
@vardhaman22 vardhaman22 merged commit 63f77aa into rancher:dev-v2.9 Mar 19, 2024
5 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request May 14, 2024
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants