-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.9] remove psp related hull tests and bump helm to v3.14.1 #3495
[v2.9] remove psp related hull tests and bump helm to v3.14.1 #3495
Conversation
@vardhaman22 Instead of using the convention of |
@vardhaman22 what is the status of this PR? Still WIP? |
@adamkpickering i faced an issue while trying to bump helm to v3.14.1 and raised a PR to fix it in hull. so we will not be able to merge this till that gets fixed. I have updated the PR description. |
hi @adamkpickering @recena since I am not sure who is going to review the hull PR for the fix, it used to be eliyam but he has left the org.. not sure who is maintaining hull repo now. So I have created a PR to disable the hull tests, so that we can bump helm here for now. |
Why do you need to disable the test to upgrade Helm? |
@recena because of the helm upgrade there is an issue in parsing templates in hull. so that needs to be fixed in hull first and then only the tests will start passing. I have explained the issue in detail in hull PR |
I assume this PR is blocked by rancher/hull#43, right? |
yes |
@vardhaman22 rancher/hull#43 is merged now. That unblocks this, right? |
4080e7a
to
7a07219
Compare
yes @adamkpickering i have updated the description of the PR and also rebased it. The CI for hull tests also passed so now it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d2aa7d6
to
cde989f
Compare
Issue
bumping helm to latest v3.14.1 version for tests
Problem
since helm v3.14.1 uses k8s libraries 0.29.x and psps are completely removed from those libraries,
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations