p0upgradeK8sVersionChecks fix #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into P1Import failure https://github.com/rancher/hosted-providers-e2e/actions/runs/12629647659/job/35188002144#step:19:169 |
valaparthvi
previously approved these changes
Jan 6, 2025
Dismissing review due to P1 import failures.
b675fc0 to
9f89427
Compare
53e2f89 to
9a8a935
Compare
valaparthvi
reviewed
Jan 8, 2025
| cluster, err = client.Management.Cluster.ByID(cluster.ID) | ||
| Expect(err).To(BeNil()) | ||
| return *cluster.EKSStatus.UpstreamSpec.KubernetesVersion | ||
| }, tools.SetTimeout(15*time.Minute), 30*time.Second).Should(Equal(upgradeToVersion)) | ||
| return *cluster.EKSStatus.UpstreamSpec.KubernetesVersion == upgradeToVersion && *cluster.EKSConfig.KubernetesVersion == upgradeToVersion |
There was a problem hiding this comment.
I don't think we need to check EKSConfig again, since we are already checking in on L80.
There was a problem hiding this comment.
True, however eks-operator/issues/668 (fixed already) occurs sometimes due to race condition.
This check ensures condition is met to start Nodegroup upgrade.
There was a problem hiding this comment.
Would you mind adding a comment about it if you haven't already? It's possible that I or someone else might forget later and remove it.
valaparthvi
approved these changes
Jan 8, 2025
Signed-off-by: Chandan Pinjani <chandan.pinjani@suse.com>
9a8a935 to
7327f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To include p0upgradeK8sVersionChecks for import tests
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #198
Checklist:
https://github.com/rancher/hosted-providers-e2e/actions/runs/12652249431
(p0_provisioning/p0_import/p1_provisioning/p1_import)