Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extraEnv to gitjob and fleet-controller deployments #2493

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Jun 7, 2024

This will enable to pass, for example, experimental features to the upstream fleet pods.

Refers to: #2465
Related to: #2114

This will enable to pass, for example, experimental features to
the upstream fleet pods.

Refers to: rancher#2465

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 added this to the v2.9.0 milestone Jun 7, 2024
@0xavi0 0xavi0 self-assigned this Jun 7, 2024
@0xavi0 0xavi0 requested a review from a team as a code owner June 7, 2024 07:58
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; has this been tested, eg. with a log message outputting the value of an env var from a controller?

@0xavi0
Copy link
Contributor Author

0xavi0 commented Jun 7, 2024

LGTM; has this been tested, eg. with a log message outputting the value of an env var from a controller?

Yeah, it has been tested with #2375

@0xavi0 0xavi0 merged commit 3d7fddb into rancher:main Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants