Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraEnvs to allow setting env vars for the controller #2465

Closed
0xavi0 opened this issue May 28, 2024 · 0 comments
Closed

Add extraEnvs to allow setting env vars for the controller #2465

0xavi0 opened this issue May 28, 2024 · 0 comments
Assignees
@0xavi0
Labels
kind/enhancement
Milestone
v2.9.0

Comments

@0xavi0
Copy link
Contributor

0xavi0 commented May 28, 2024 •
edited
Loading

We'd need a way to pass env variables into the helm chart. Rancher uses extraEnv.

By setting the EXPERIMENTAL_OCI_STORAGE env variable, the OCI storage feature could be enabled.
(Adding the EXPERIMENTAL_ prefix to make it clear that this feature is at the moment experimental.)
@0xavi0 0xavi0 added this to Fleet May 28, 2024
@0xavi0 0xavi0 converted this from a draft issue May 28, 2024
@0xavi0 0xavi0 mentioned this issue May 28, 2024
Closed
4 tasks
@manno manno changed the title Add new feature flag for enabling experimental features Add extraEnvs to allow setting env vars for the controller May 28, 2024
@manno manno moved this from 🆕 New to 📋 Backlog in Fleet May 28, 2024
@manno manno added this to the v2.9.0 milestone May 28, 2024
@0xavi0 0xavi0 self-assigned this Jun 4, 2024
@manno manno moved this from 📋 Backlog to 🏗 In progress in Fleet Jun 5, 2024
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Jun 7, 2024
@0xavi0
Adds extraEnv to gitjob and fleet-controller deployments
3a0fe71 
This will enable to pass, for example, experimental features to
the upstream fleet pods.

Refers to: rancher#2465

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0 added a commit to 0xavi0/fleet that referenced this issue Jun 7, 2024
@0xavi0
Adds extraEnv to gitjob and fleet-controller deployments
480e48e 
This will enable to pass, for example, experimental features to
the upstream fleet pods.

Refers to: rancher#2465

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 mentioned this issue Jun 7, 2024
Merged
0xavi0 added a commit that referenced this issue Jun 7, 2024
@0xavi0
Adds extraEnv to gitjob and fleet-controller deployments (#2493)
3d7fddb 
This will enable to pass, for example, experimental features to
the upstream fleet pods.

Refers to: #2465

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@weyfonk weyfonk closed this as completed Jun 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Fleet Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xavi0 0xavi0

Labels
kind/enhancement
Projects
Fleet
Archived in project
Milestone
v2.9.0
Development

No branches or pull requests
3 participants
@manno @weyfonk @0xavi0