Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on machine reg tab instead of inventory #504

Merged

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Nov 8, 2022

When you create a machine registration, the machine inventory tab is selected by default, to me, it would be more logical to get the machine registration tab as default. I informed @aalves08 about that anyway.

image

That means the wrong tab is used for the test, this PR adds a click on the machine registration tab to fill correct labels and annotations.

Verification:
image

@juadk juadk marked this pull request as draft November 8, 2022 14:27
@juadk juadk force-pushed the use_correct_tab_for_machine_registration_label_annotation branch from a458e0b to bce177d Compare November 8, 2022 14:43
@juadk juadk marked this pull request as ready for review November 8, 2022 14:45
@juadk juadk added the kind/QA label Nov 8, 2022
@juadk juadk self-assigned this Nov 8, 2022
@juadk juadk force-pushed the use_correct_tab_for_machine_registration_label_annotation branch from bce177d to 8785a04 Compare November 8, 2022 15:37
@juadk juadk merged commit 9ef3769 into main Nov 8, 2022
@juadk juadk deleted the use_correct_tab_for_machine_registration_label_annotation branch November 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants