Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default label and annotation tab in machine registration #37

Closed
juadk opened this issue Nov 8, 2022 · 3 comments
Closed

Default label and annotation tab in machine registration #37

juadk opened this issue Nov 8, 2022 · 3 comments

Comments

@juadk
Copy link
Collaborator

juadk commented Nov 8, 2022

I would find more logical to see Machine Registration as default tab as we are in the machine registration menu instead of the machine inventory tab.

But in the other hand, the user has much more interest in filling out labels and annotations for machine inventories because they are useful for advanced filtering and identifying machines rather than the actual labels and annotations for machine registrations

image

Anyway I have updated my test code to switch on the good tab rancher/elemental#504
And I have to push a new code to test the new machine inventories tab.

@agracey @kwwii WDYT?

@kwwii
Copy link

kwwii commented Nov 8, 2022

I think that the main use-case here is to add labels to the inventories (I think mainly so that they can be added to clusters).
I don't know of any use-cases for adding labels or annotations to the machine registration resource itself.

@juadk
Copy link
Collaborator Author

juadk commented Nov 9, 2022

Well I think you are right, the main purpose is adding labels to the inventories, thanks.

@juadk juadk closed this as completed Nov 9, 2022
@agracey
Copy link

agracey commented Nov 9, 2022

I think a better way to help here is to give a description in each tab about the purpose of the fields. This can be very confusing to new users so additional ways we can help understanding are useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants