Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getting filters #51

Closed
keiranjprice101 opened this issue Sep 10, 2019 · 0 comments · Fixed by #57
Closed

Refactor getting filters #51

keiranjprice101 opened this issue Sep 10, 2019 · 0 comments · Fixed by #57
Labels
refactor

Comments

@keiranjprice101
Copy link
Collaborator

Currently there is a lot of unnecessary duplication with filtering. The factory method is called in a lot of places. It could alternatively be used once when the filters are taken from the query strings.

The filter handler could also be given a method to take in a list of filters instead of looping through the filters and adding them separately (which is currently done in a lot of places)
keiranjprice101 added a commit that referenced this issue Sep 11, 2019
@keiranjprice101
#51: Make Querystring filter method return filter objects
33ea947
keiranjprice101 added a commit that referenced this issue Sep 11, 2019
@keiranjprice101
#51: Add method to add a list of filters to filter handler
9c6cfb1
keiranjprice101 added a commit that referenced this issue Sep 11, 2019
@keiranjprice101
#51: Use add filters method
147ec49
keiranjprice101 added a commit that referenced this issue Sep 11, 2019
@keiranjprice101
#51: Change include filter
958da33
keiranjprice101 added a commit that referenced this issue Sep 11, 2019
@keiranjprice101
#51: Use updated include filter
ce6beb7
@keiranjprice101 keiranjprice101 mentioned this issue Sep 11, 2019
Merged
keiranjprice101 added a commit that referenced this issue Sep 12, 2019
@keiranjprice101
#51: Update _get_results_with_include
1b2a389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor getting filters ral-facilities/datagateway-api
1 participant
@keiranjprice101