Skip to content

Commit

Permalink
#51: Use add filters method
Browse files Browse the repository at this point in the history
  • Loading branch information
keiranjprice101 committed Sep 11, 2019
1 parent 9c6cfb1 commit 147ec49
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions common/database_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,7 @@ def get_filtered_read_query_results(filter_handler, filters, query):
:return: The results of the query as a list of dictionaries
"""
try:
for query_filter in filters:
if len(query_filter) == 0:
pass
else:
filter_handler.add_filter(QueryFilterFactory.get_query_filter(query_filter))
filter_handler.add_filters(filters)
filter_handler.apply_filters(query)
results = query.get_all_results()
if query.include_related_entities:
Expand Down Expand Up @@ -376,11 +372,7 @@ def get_filtered_row_count(table, filters):
log.info(f" getting count for {table.__tablename__}")
count_query = CountQuery(table)
filter_handler = FilterOrderHandler()
for query_filter in filters:
if len(query_filter) == 0:
pass
else:
filter_handler.add_filter(QueryFilterFactory.get_query_filter(query_filter))
filter_handler.add_filters(filters)
filter_handler.apply_filters(count_query)
return count_query.get_count()

Expand Down Expand Up @@ -454,11 +446,7 @@ def get_investigations_for_user_count(user_id, filters):
"""
count_query = UserInvestigationsCountQuery(user_id)
filter_handler = FilterOrderHandler()
for query_filter in filters:
if len(query_filter) == 0:
pass
else:
filter_handler.add_filter(QueryFilterFactory.get_query_filter(query_filter))
filter_handler.add_filters(filters)
filter_handler.apply_filters(count_query)
return count_query.get_count()

Expand Down

0 comments on commit 147ec49

Please sign in to comment.