Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement remaining endpoints for python-icat #145

Closed
5 tasks done
stuartpullinger opened this issue Jun 17, 2020 · 0 comments · Fixed by #171
Closed
5 tasks done

implement remaining endpoints for python-icat #145

stuartpullinger opened this issue Jun 17, 2020 · 0 comments · Fixed by #171
Assignees
@MRichards99
Milestone
Implement the rem...

Comments

@stuartpullinger
Copy link
Contributor

stuartpullinger commented Jun 17, 2020 •
edited by MRichards99
Loading

  • count for the get all endpoint
  • get one
  • create entity/row
  • update
  • delete
@MRichards99 MRichards99 self-assigned this Sep 29, 2020
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Basic implementation of /count
5fd2622 
- Currently breaks when you add a distinct filter so that needs fixing
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Allow /count to work with distinct filters
86c6f27
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Fix bug on non-count queries
692ac0f
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Implement /findone for all entities
0747c5b
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Remove to_dict() conversion on PATCH entity endpoints
a4baba3 
- Python ICAT backend doesn't need this conversion, so this has been moved into the relevant DB backend helper function
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Fix bug where GET requests without distinct filter sometimes r…
d3a0f0b 
…eturn a 400
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Add basic implementation of updating multiple entities in one …
4f549bc 
…request

- This works some of the time, but not all as of this commit
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Prevent related entities from displaying in response of a PATC…
2970dde 
…H request

- Related entities (i.e. includes="1") must be retrieved when updating data to avoid an IcatException which highlights that a related entity field is trying to be set to null which is invalid
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Add docstring for ICAT PATCH helper function
b33de8a
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Add first implementation of POST request (create) for entities
944b877 
- This has only been tested on /investigations so far, so further changes may be needed when I test on the rest of the entities
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Allow Python ICAT names to be fetched as camelCase
5cb5068 
- This is required for created ICAT objects in Python ICAT
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Remove parameter from str_to_datetime_object()
5eed66e 
- I've also made use of this in create_entities() which made me notice that said parameter wasn't used
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Deal with attributes that have MANY relationships
85860ff 
- This code needs to be recursed over, since multiple 'levels' of mandatory MANY relationships don't happen currently and this results in a database related error
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Remove unused code
be3c797 
- Recursing through related objects is no longer required
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Add exception to be caught when creating ICAT data
d7741f7
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Move date-related functions to a separate class
2a88aae 
- In the future, these could be used by other backends so I've moved these 3 functions into their own utility class. This change helps clean up common.icat.helpers a bit which is another reason this change has been made
MRichards99 added a commit that referenced this issue Oct 8, 2020
@MRichards99
#145: Add logging
1f866f1
MRichards99 added a commit that referenced this issue Oct 9, 2020
@MRichards99
#145: Make small changes to date handler
b8534e4
MRichards99 added a commit that referenced this issue Oct 9, 2020
@MRichards99
#145: Add LIMIT filter into /findone endpoints
264c130 
- This helps to make these types of requests more snappy, without impacting the output
MRichards99 added a commit that referenced this issue Oct 9, 2020
@MRichards99
#145: Remove return_first_value_only flag
2d2f4f1 
- This functionality has been replaced with a limit filter as per the previous commit
MRichards99 added a commit that referenced this issue Oct 9, 2020
@MRichards99
#145: Move filter-specific functions to FilterOrderHandler
8c8a241 
- This will help clean up common.icat.helpers and move filter-specific functions to the relevant file
- This commit also adds a function that calls other functions in its class to reduce code duplication
- This is a 'leave the code in a better state than you found it' kind of commit
MRichards99 added a commit that referenced this issue Oct 9, 2020
@MRichards99
#145: Remove logging statement from development work
8e046f6
@MRichards99 MRichards99 mentioned this issue Oct 9, 2020
Merged
@MRichards99 MRichards99 linked a pull request Oct 9, 2020 that will close this issue
Implement Remaining Standard Endpoints for Python ICAT Backend #171
Merged
MRichards99 added a commit that referenced this issue Nov 20, 2020
@MRichards99
#145: Ensure updated data is pushed at the end of the request
ed562e8 
- This will prevent an issue where you're updating multiple pieces of data and the request returns a 400, you don't know which pieces of data have been updated
MRichards99 added a commit that referenced this issue Nov 20, 2020
@MRichards99
#145: Ensure the database remains in a similar state to what it star…
b6395e5 
…ted in if POST returns an error

- Similar purpose to the previous commit but expanded so changes are 'rolled back' if an exception occurs on the .create()
MRichards99 added a commit that referenced this issue Nov 20, 2020
@MRichards99
#145: Add attempt to restore old data if an update goes wrong
3224a27 
- This is a solution to a comment made on the PR for this branch
- This solution doesn't need to be applied to update by ID because if an error occurs there, there's no other data that could possibly be updated
MRichards99 added a commit that referenced this issue Dec 2, 2020
@MRichards99
#145: Correct mistake made in merge conflict resolution
ed3fe4f
MRichards99 added a commit that referenced this issue Jan 5, 2021
@MRichards99
#145: Improve datetime conversion
e8c13e9 
- The 'accepted_date_format' constant is removed since it's no longer used. Datetime to string conversion will convert to ISO format and string to datetime can be converted using the same format (allowing for easy-tripping of datetimes for API users).
MRichards99 added a commit that referenced this issue Jan 5, 2021
@MRichards99
#145: Improve the GET /sessions helper function
d6bff57 
- Remove rounding on the expireDateTime value and ensure it always returns a consistent, accurate result
- Change the keys to camelCase, in line with the rest of the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRichards99 MRichards99

Labels
None yet
Projects
None yet
Milestone
Implement the remaining endpoints
Development

Successfully merging a pull request may close this issue.

Implement Remaining Standard Endpoints for Python ICAT Backend ral-facilities/datagateway-api
2 participants
@stuartpullinger @MRichards99