#145: Remove to_dict() conversion on PATCH entity endpoints

- Python ICAT backend doesn't need this conversion, so this has been moved into the relevant DB backend helper function
ral-facilities · Oct 1, 2020 · a4baba3 · a4baba3
1 parent 0747c5b
commit a4baba3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/common/database/helpers.py b/common/database/helpers.py
@@ -426,14 +426,14 @@ def patch_entities(table, json_list):
             if key.upper() == "ID":
                 update_row_from_id(table, json_list[key], json_list)
                 result = get_row_by_id(table, json_list[key])
-                results.append(result)
+                results.append(result.to_dict())
     else:
         for entity in json_list:
             for key in entity:
                 if key.upper() == "ID":
                     update_row_from_id(table, entity[key], entity)
                     result = get_row_by_id(table, entity[key])
-                    results.append(result)
+                    results.append(result.to_dict())
     if len(results) == 0:
         raise BadRequestError(f" Bad request made, request: {json_list}")
 

diff --git a/src/resources/entities/entity_endpoint.py b/src/resources/entities/entity_endpoint.py
@@ -108,13 +108,8 @@ def post(self):
 
         def patch(self):
             return (
-                list(
-                    map(
-                        lambda x: x.to_dict(),
-                        backend.update(
-                            get_session_id_from_auth_header(), table, request.json
-                        ),
-                    )
+                backend.update(
+                    get_session_id_from_auth_header(), table, request.json
                 ),
                 200,
             )