Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove toolchain #4

Merged
merged 1 commit into from
Sep 14, 2024
Merged

chore: remove toolchain #4

merged 1 commit into from
Sep 14, 2024

Conversation

ldez
Copy link
Collaborator

@ldez ldez commented Sep 14, 2024

No description provided.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (1a5e0de) to head (bcfcfd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files           1        1           
  Lines          31       31           
=======================================
  Hits           25       25           
  Misses          4        4           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldez
Copy link
Collaborator Author

ldez commented Sep 14, 2024

IMHO codecov is useless tool, that just produces pollution on PR.

The coverage is something important but it's not a goal.

@raeperd
Copy link
Owner

raeperd commented Sep 14, 2024

Yeah I agree
I will disable it for PR

Edit: Disabled PR comment so there is no comments on PR
Codecov is only used for tracking coverage not to achieve some percent

@raeperd raeperd self-requested a review September 14, 2024 00:38
Copy link
Owner

@raeperd raeperd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@raeperd raeperd merged commit e27662d into main Sep 14, 2024
5 checks passed
@raeperd raeperd deleted the ldez-patch-1 branch September 14, 2024 05:01
@raeperd raeperd restored the ldez-patch-1 branch September 14, 2024 05:01
@ldez ldez deleted the ldez-patch-1 branch September 14, 2024 12:29
@ldez ldez mentioned this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants