Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add coverall integration #13

Merged
merged 5 commits into from
Jan 18, 2025
Merged

ci: add coverall integration #13

merged 5 commits into from
Jan 18, 2025

Conversation

raeperd
Copy link
Owner

@raeperd raeperd commented Jan 18, 2025 •
edited by ldez
Loading

  • ci: Add coverall integration
  • ci: Add branch for test run ci
  • docs: Add badge

@raeperd raeperd added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2025
@raeperd raeperd self-assigned this Jan 18, 2025
@ldez ldez closed this Jan 18, 2025
@ldez ldez reopened this Jan 18, 2025
@ldez
Copy link
Collaborator

ldez commented Jan 18, 2025 •
edited
Loading

sorry missclick

@ldez
Copy link
Collaborator

ldez commented Jan 18, 2025

I still think the same thing about coverall/codecov #4 (comment)

@raeperd
Copy link
Owner Author

raeperd commented Jan 18, 2025 •
edited
Loading

@ldez
I completely agree that adding coverage-related comments to PRs can unnecessarily clutter the discussion.

I consider code coverage to be a nice-to-have metric rather than a decisive factor.
It’s not something I use as a basis for merging PRs, so I’ve disabled PR comments related to coverage changes.

I hope this serves as a good reference for other users of this repository as well

@ldez
Copy link
Collaborator

ldez commented Jan 18, 2025

coverall action will be called on all PRs, is it intentional?

@raeperd
Copy link
Owner Author

raeperd commented Jan 18, 2025

that is not intended. thanks will fix it

@ldez ldez changed the title ci: Add coverall integration ci: add coverall integration Jan 18, 2025
ldez
ldez approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 3d52e02 into main Jan 18, 2025
8 checks passed
@ldez ldez deleted the ci-coverall branch January 18, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees

@raeperd raeperd

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raeperd @ldez