Merge pull request #1224 from rabbitmq/rabbitmq-dotnet-client-1223-6.x #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better integrate max message size (cherry picked from commit ec8e552)
michaelklishin
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better integrate max message size
(cherry picked from commit ec8e552)
Fixes #1225
See #1213, #1217, #1220 and #1223
The TL;DR is that unusual network issues caused this client to incorrectly allocate over 1 GiB of memory due to reading an invalid frame. An old FIXME comment suggested that a maximum be set on this. I implemented this in 6.4.0 and forward-ported it here.
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/6.x/CHANGELOG.md#changes-between-631-and-640