Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integrate max message size #1223

Closed
lukebakken opened this issue Jun 10, 2022 · 3 comments
Closed

Better integrate max message size #1223

lukebakken opened this issue Jun 10, 2022 · 3 comments
Assignees
@lukebakken
Milestone
6.4.0

Comments

@lukebakken
Copy link
Contributor

Some more work needs to be done on AmqpTcpEndpoint and ConnectionFactory
@lukebakken lukebakken added this to the 6.4.0 milestone Jun 10, 2022
@lukebakken lukebakken self-assigned this Jun 10, 2022
@lukebakken
Copy link
Contributor Author

In particular, check out RequestedFrameMax and Connection.MaxPayloadSize after negotiation.

@lukebakken
Copy link
Contributor Author

Unfortunately this is not what we're looking for - https://www.rabbitmq.com/amqp-0-9-1-reference.html#connection.tune-ok.frame-max

We'll just have to use a default that matches RabbitMQ.

lukebakken added a commit that referenced this issue Jun 13, 2022
@lukebakken
Better integrate max message size
d8721fe 
Fixes #1223 for 6.x
lukebakken added a commit that referenced this issue Jun 13, 2022
@lukebakken
Better integrate max message size
917ad15 
Fixes #1223 for 6.x
@lukebakken lukebakken mentioned this issue Jun 13, 2022
Merged
lukebakken added a commit that referenced this issue Jun 14, 2022
@lukebakken
Better integrate max message size
0305546 
Fixes #1223 for 6.x

Integrate MaxMessageSize into ConnectionFactory

Update APIApproval

CHANGELOG

Handle excessive payload size with hard protocol exception

Add tests for MaxMessageSize

Update API
lukebakken added a commit that referenced this issue Jun 14, 2022
@lukebakken
Better integrate max message size
5930d91 
Fixes #1223 for 6.x

Integrate MaxMessageSize into ConnectionFactory

Update APIApproval

CHANGELOG

Handle excessive payload size with hard protocol exception

Add tests for MaxMessageSize

Update API
@lukebakken
Copy link
Contributor Author

Fixed by #1224

This was referenced Jun 14, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

No branches or pull requests
1 participant
@lukebakken