Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate runtimes #46

Merged
merged 24 commits into from
Mar 27, 2024

Merge pull request #52 from r0gue-io/frank/feat-separate-runtimes

6293ce8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: separate runtimes #46

Merge pull request #52 from r0gue-io/frank/feat-separate-runtimes
6293ce8
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Mar 27, 2024 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 328 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Location`

warning: useless conversion to the same type: `cumulus_primitives_core::Location`
   --> runtime/testnet/src/extensions.rs:328:35
    |
328 |                 .deposit_asset(assets.into(), beneficiary.into())
    |                                               ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 328 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Location`

warning: useless conversion to the same type: `cumulus_primitives_core::Location`
   --> runtime/devnet/src/extensions.rs:328:35
    |
328 |                 .deposit_asset(assets.into(), beneficiary.into())
    |                                               ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 321 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Asset`

warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
   --> runtime/devnet/src/extensions.rs:321:20
    |
321 |                 .buy_execution(assets.clone().into(), Unlimited)
    |                                ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 321 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Asset`

warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
   --> runtime/testnet/src/extensions.rs:321:20
    |
321 |                 .buy_execution(assets.clone().into(), Unlimited)
    |                                ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default