-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate runtimes #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo test
build fails, especially with the integration-tests
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly just suggestions apart from the potential issue with async-backing enabled on Paseo. We might need to switch all the items noted in https://wiki.polkadot.network/docs/maintain-guides-async-backing#phase-3---activate-async-backing off when deploying to Paseo, which could be done with an async-backing
feature flag.
Will address your comments @evilrobot-01 and maybe also move the definition of I've just noticed that even if we are setting the spec correctly we still have this fixed definition in the runtime. |
Probably need a better feature name than async-backing then. As Rococo is short term, maybe we just use |
A suggestion is to diff the lib.rs file of both testnet & devnet, and perhaps the others just to be sure, and check for inconsistencies. I see the struct |
Agreed, it is important that these two align, at least in terms of structure, so that they can easily be diffed to ensure certain things are not missing. They will diverge over time, but need to be able to easily diff to ensure what should be the same, is the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Agree with Frank's comments from above about using runtime alias to simplify naming.
Enum variants should be sentence-cased rather than capitalised.
Regression from main as result of runtime split
Devnet always used when resolved to default, so just uses devnet and removes the additional default variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a PR to this one, addressing the outstanding comments. Once that is accepted and merged into this one, I am good to proceed.
refactor: separate runtimes
This PR separates the runtime into two different ones
It configures the corresponding chain specs and its configurations depending the relay chain the network is aimed to be deployed on:
dev-rococo
dev-paseo
pop-rococo
pop-paseo
Also includes the specs generated for
rococo
andpaseo
from this code base.I have created a pair of accounts to have a place holder in the chain spec for the testnet options, I'll be curious to know your opinions there. Aura keys might need to be changed.
A new feature has been included
paseo
to set the corresponding runtime values for deploying in Paseo testnet.This feature sets the runtime for sync backing and uses monetary unit of 10 decimals.
Not activating this feature will default to set the runtime to work with async backing and a monetary unit of 12 decimals.