fix: adds delivery fees config and base weights #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can we add some unit tests in the runtime to assert that these values are set correctly, and remain that way so that no regressions occur? |
|
Can we reorder base-parachain/runtime/src/lib.rs Line 539 in 9a312bb It would be good to also add a comment somewhere within construct_runtime as a reminder to ensure that they are added to define_benchmarks, for any template users. |
weezy20
reviewed
May 3, 2024
# Conflicts: # node/src/chain_spec.rs # runtime/src/lib.rs # runtime/src/xcm_config.rs
evilrobot-01
approved these changes
May 3, 2024
Daanvdplas
approved these changes
May 4, 2024
peterwht
approved these changes
May 4, 2024
AlexD10S
referenced
this pull request
in r0gue-io/contracts-parachain
May 10, 2024
* ci: add workflow (#12) * chore: pin rust channel to version used for polkadot * style: formatting using rust version * refactor: address clippy warnings * ci: add workflow * ci: add missing packages * ci: various fixes * ci: use cache * fix: adds delivery fees config and base weights (#11) * fix(base): delivery fees * fix(base): declare WeightInfo for every pallet * style(base): fmt * style(base): undo fmt * fix(base): remove example zombienet file * fix(base): Add treasury clarification * fix(base): weights & benchmarks * fix: remove erroneous pallets * docs: add benchmark comment for consistency * fix(runtime): use unit type for weightinfo for consistency * docs(runtime): add additional context * fix(xcm): filter teleports to disable --------- Co-authored-by: Frank Bell <frank@r0gue.io> * chore: remove deprecated polkadot-launch (r0gue-io#14) * ci: add workflow for linting pr titles (r0gue-io#15) * fix: update default para id * chore: sync with base parachain --------- Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com> Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com> Co-authored-by: Frank Bell <frank@r0gue.io> Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default configuration for delivery fees that doesn't charge to the relay nor the sibling system parachains and collecting the fee in the account corresponding to the treasury module (non existent in the template right now) .
Also declares the type
WeightInfofor each pallet with the base weights provided in the pallet.Motivation for changes comes from similarities found at SRLabs audit: https://github.com/OpenZeppelin/polkadot-generic-runtime-template/blob/main/audits/2024-04.pdf