Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to stable2409 #12

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Jan 2, 2025

Uplift asset-parachain template to stable2409 - Release Changelog. Configure pallet-revive for the runtime. By default, ETH RPC is not configured.

Status

  • ✅ Builds node & runtime successfully.
  • ✅ Parachain node produce blocks with PASEO local.
  • ✅ Deploy a new contract successfully with pop-cli
┌   Pop CLI : Deploy a smart contract
│
▲  NOTE: contract has not yet been built.
│
◇  Your contract artifacts are ready. You can find them in: /Users/chungquantin/Developer/pop-network/contracts-parachain/target/ink/my_contract
│
◇  Gas limit estimate: Weight { ref_time: 179608473, proof_size: 26643 }
│
◇  Contract deployed and instantiated: The Contract Address is "5E4z7LvRkgpAftqFuYSDRYW9q3TVnY8ybF5Mjnqhbr6qYhD4"
│
└  🚀 Deployment complete

Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look alright! Thanks!

If anything, given that we are introducing revive, it might make sense pointing in the README that users need to deploy this proxy server:

Which emulates the Ethereum Json RPC. So that's the server eth dapps and wallets want to connect to instead of the node directly.

Also this is the REMIX version that should be used:

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One thing before merging: please remove the network.toml file, as pop-cli generates it automatically. For future reference, it might be a good idea to add a line to .gitignore to prevent this in the future.

I was able to manually deploy a contract using pallet_revive. However, until pop-cli is fully compatible, it might not be worth adding too much detail about revive in the README. Perhaps just include a note for developers mentioning that the template includes pallet_revive and pallet_contracts for those who want to start exploring.

Maybe @al3mart's suggestion here is worth adding, especially if we plan to deprecate the EVM template in favor of this one: #12 (review).
However, I’m not sure if it falls out of scope without a proper update to the documentation.

@chungquantin chungquantin force-pushed the chungquantin/chore-upgrade-stable2409 branch from d81c05c to ecb7855 Compare January 9, 2025 07:56
@chungquantin chungquantin requested a review from AlexD10S January 9, 2025 07:56
@chungquantin
Copy link
Collaborator Author

chungquantin commented Jan 9, 2025

Nice work! One thing before merging: please remove the network.toml file, as pop-cli generates it automatically. For future reference, it might be a good idea to add a line to .gitignore to prevent this in the future.

I was able to manually deploy a contract using pallet_revive. However, until pop-cli is fully compatible, it might not be worth adding too much detail about revive in the README. Perhaps just include a note for developers mentioning that the template includes pallet_revive and pallet_contracts for those who want to start exploring.

Maybe @al3mart's suggestion here is worth adding, especially if we plan to deprecate the EVM template in favor of this one: #12 (review). However, I’m not sure if it falls out of scope without a proper update to the documentation.

Apologies, I remember excluding network.toml already. Resolve by updating the README and removing network.toml.

@chungquantin chungquantin merged commit 75db0e1 into main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants