Issue325 object length linter #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
======================================
Coverage 85.6% 85.6%
======================================
Files 41 41
Lines 2132 2132
======================================
Hits 1825 1825
Misses 307 307
Continue to review full report at Codecov.
|
jimhester
reviewed
Aug 13, 2018
R/zzz.R
Outdated
| @@ -94,7 +94,7 @@ default_linters <- with_defaults(default = list(), | |||
| infix_spaces_linter, | |||
| line_length_linter(80), | |||
| no_tab_linter, | |||
| object_length_linter(30), | |||
| object_length_linter, | |||
There was a problem hiding this comment.
This still needs to be a call, e.g. object_length_linter()
…intr into issue325-object-length-linter
|
Thanks! Could you add a note to NEWS.md with this change; referencing the issue number and your GitHub username, then I can merge this. |
|
Note added to NEWS.md. Thanks! |
jimhester
approved these changes
Sep 18, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the default value of the length argument 30 (consistent across use, test, etc). This should close issue #325.