Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object_length_linter consistent accross #325

Closed
gdequeiroz opened this issue Jun 6, 2018 · 1 comment
Closed

Make object_length_linter consistent accross #325

gdequeiroz opened this issue Jun 6, 2018 · 1 comment
Assignees
Labels
good first issue ❤️ good issue for first-time contributors

Comments

@gdequeiroz
Copy link
Collaborator

It looks like the default argument for theobject_length_linter function is 20:
https://github.com/jimhester/lintr/blob/3312afafafd673aa7ec74231b39d83038508023c/R/object_name_linters.R#L182

but the default for calling it is 30:
https://github.com/jimhester/lintr/blob/87658ec425ca5cb2c733444ab6beef45dbb31cfe/R/zzz.R#L96

It makes sense to make them consistent, so we should change the default argument to 30.

@gdequeiroz gdequeiroz self-assigned this Jun 6, 2018
@gdequeiroz gdequeiroz added the good first issue ❤️ good issue for first-time contributors label Jun 6, 2018
@dragosmg
Copy link
Collaborator

I think this issue can be closed. Thanks @gdequeiroz for the good first issue label and thanks @jimhester for reviewing and approving my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue ❤️ good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

2 participants