Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all missing arguments when several are in the same call #2400

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2399

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e84ab51) 98.68% compared to head (8b4bf58) 98.68%.

❗ Current head 8b4bf58 differs from pull request most recent head 9006881. Consider uploading reports for the commit 9006881 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2400   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         126      126           
  Lines        5697     5698    +1     
=======================================
+ Hits         5622     5623    +1     
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico merged commit e1862b2 into main Dec 6, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the fix-missing branch December 6, 2023 08:30
MichaelChirico added a commit that referenced this pull request Mar 21, 2024
* also test allow_missing=TRUE case

* narrow line

* restore ddeleted test

---------

Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_argument_linter() incorrect for multiple missing arguments
3 participants