Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_argument_linter() incorrect for multiple missing arguments #2399

Closed
MichaelChirico opened this issue Dec 6, 2023 · 2 comments · Fixed by #2400
Closed

missing_argument_linter() incorrect for multiple missing arguments #2399

MichaelChirico opened this issue Dec 6, 2023 · 2 comments · Fixed by #2400
Labels
false-negative code that should lint, but doesn't
Milestone
3.2.0

Comments

@MichaelChirico
Copy link
Collaborator 

lint(text = "foo(,,)", linters = missing_argument_linter())
# <text>:1:5: style: [missing_argument_linter] Missing argument 1 in function call.
# foo(,,)
#     ^
# <text>:1:6: style: [missing_argument_linter] Missing argument 2 in function call.
# foo(,,)
#      ^

But there are three missing arguments.
@MichaelChirico MichaelChirico added the false-negative code that should lint, but doesn't label Dec 6, 2023
@MichaelChirico MichaelChirico added this to the 3.2.0 milestone Dec 6, 2023
@AshesITR

This comment was marked as resolved.

Sign in to view
@MichaelChirico

This comment was marked as resolved.

Sign in to view
@MichaelChirico MichaelChirico mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-negative code that should lint, but doesn't
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Catch all missing arguments when several are in the same call r-lib/lintr
2 participants
@AshesITR @MichaelChirico