Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal_newline_linter #675

Closed
MichaelChirico opened this issue Dec 4, 2020 · 5 comments · Fixed by #732
Closed

terminal_newline_linter #675

MichaelChirico opened this issue Dec 4, 2020 · 5 comments · Fixed by #732
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help!
Milestone
3.0.0

Comments

@MichaelChirico
Copy link
Collaborator

Add a linter which checks for terminal newlines in source.

Alternatively, we could extend/adjust trailing_blank_lines_linter to work for this case as well.
@AshesITR
Copy link
Collaborator

AshesITR commented Dec 4, 2020

I like the idea of extending trailing_blank_lines_linter since it's so similar in functionality already.

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Dec 4, 2020 via email

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 4, 2020

Me too. It still looks at trailing blank lines.

@russHyde russHyde added the feature a feature request or enhancement label Dec 9, 2020
@russHyde
Copy link
Collaborator

russHyde commented Dec 9, 2020

Crossref: #50

This was referenced Jan 31, 2021
Closed
Closed
@AshesITR
Copy link
Collaborator

#562 made this trivial.
It should check if terminal_newline is FALSE and lint the last line, last column of the file.
The lint position would allow fixing the lint by jumping to its marker and hitting Enter

@AshesITR AshesITR added good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! labels Jan 31, 2021
@AshesITR AshesITR added this to the 3.0.0 milestone Jan 31, 2021
AshesITR added a commit that referenced this issue Feb 3, 2021
@AshesITR
add trailing_blank_lines lint at end of file if terminal_newline is m…
503f176 
…issing

I had to fix `parse_exclusions()` as well because the `readLines()` used there didn't muffle the incomplete final line lint.

fixes #675

 - [x] implement
 - [x] test
 - [x] write NEWS bullet
@AshesITR AshesITR mentioned this issue Feb 3, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help!
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

add trailing_blank_lines lint at end of file if terminal_newline is missing r-lib/lintr
3 participants
@AshesITR @MichaelChirico @russHyde