Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline at end of file linter #50

Closed
jimhester opened this issue Feb 11, 2015 · 3 comments
Closed

Newline at end of file linter #50

jimhester opened this issue Feb 11, 2015 · 3 comments
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

while readLines does throw a warning in this case we should also generate a lint (and probably catch the warning).

This error is basically impossible to generate using vim and emacs, but very easy to do with RStudio.

@Arcanemagus
Copy link
Contributor

This is also pretty easy to trigger within Atom since the new integration for that lints the contents on the fly.
image

@jimhester
Copy link
Member Author

@Arcanemagus I just updated the atom linter code to append a newline to the file from the buffer, which fixes this issue AtomLinter/linter-lintr@7ff6d0c.

@jimhester jimhester added feature a feature request or enhancement and removed enhancement labels May 17, 2018
@MichaelChirico
Copy link
Collaborator

OG version of #675 / #719; closing as superseded by those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants