-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mockery #59
Remove mockery #59
Conversation
Fixes r-lib#57 I don't love the implementation for package.R. If there's a less-kludgey way to do that, I'd be happy to do so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few style nitpicks to fix
Thanks much! I simplified it a bit and avoided some mocks. This would mess up debugme if it was used while running the tests, but that's quite unlikely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn't feel great about how I implemented things, but didn't have a better solution that kept testing roughly equivalent. It's useful to see what you did!
Fixes #57
I don't love the implementation I used in package.R. If there's a less-kludgey way to do that, I'd be happy implement it (and learn the trick)!