Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testthat::with_mock() instead of mockery #57

Closed
gaborcsardi opened this issue Jul 17, 2024 · 0 comments · Fixed by #59
Closed

Use testthat::with_mock() instead of mockery #57

gaborcsardi opened this issue Jul 17, 2024 · 0 comments · Fixed by #59
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@gaborcsardi
Copy link
Member

No description provided.

@gaborcsardi gaborcsardi added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jul 17, 2024
jonthegeek added a commit to jonthegeek/debugme that referenced this issue Aug 15, 2024
Fixes r-lib#57

I don't love the implementation for package.R. If there's a less-kludgey way to do that, I'd be happy to do so!
gaborcsardi added a commit that referenced this issue Aug 28, 2024
* Remove mockery

Fixes #57

I don't love the implementation for package.R. If there's a less-kludgey way to do that, I'd be happy to do so!

* Address review comments.

* Slightly clearer commenting about is_debugged().

* Simplify testing, to aboid changing the package code

* Avoid whitespace changes

* Simpligy tests

---------

Co-authored-by: Gábor Csárdi <csardi.gabor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant