Use dynamic fastfield codes for multivalues fixes #1093 #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Jun 25, 2021
fulmicoton
reviewed
Jun 25, 2021
fulmicoton
reviewed
Jun 25, 2021
fulmicoton
approved these changes
Jun 25, 2021
fulmicoton
reviewed
Jun 25, 2021
fulmicoton
reviewed
Jun 25, 2021
fastfield_codecs/src/lib.rs
Outdated
| fn get(&self, doc: u32) -> u64 { | ||
| self[doc as usize] | ||
| fn get_val(&self, position: u64) -> u64 { | ||
| self[position as usize] | ||
| } | ||
| } | ||
|
|
||
| impl<'a> FastFieldDataAccess for &'a Vec<u64> { |
There was a problem hiding this comment.
I suspect this one is useless...
There was a problem hiding this comment.
because &[u64] exists? type deduction doesn't work in some case properly
fulmicoton
reviewed
Jun 25, 2021
Use dynamic fastfield codes for multivalues fixes (only sorting case covered) Rename get to get_val due to conflict with Vec use u64 precision instead of u32 for get_range, to allow use of existing fast field interface interface (actually not sure if it would be better have a different interface)
add dynamic fastfield for single fast field unsorted fix scary documentation bug add num_len instead of len
make docid mapping non optional add trivial flag for docid mapping add time measurements
fulmicoton
reviewed
Jun 30, 2021
Cargo.toml
Outdated
| @@ -53,6 +53,7 @@ rayon = "1.5" | |||
| lru = "0.6.5" | |||
| fastdivide = "0.3" | |||
| itertools = "0.10.0" | |||
| measure_time = "0.6.0" | |||
fulmicoton
reviewed
Jun 30, 2021
fulmicoton
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dynamic fastfield codes for multivalues fixes (only sorting case covered)
Rename get to get_val due to conflict with Vec
use u64 precision instead of u32 for get_range, to allow use of existing fast field interface interface (actually not sure if it would be better have a different interface)