Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock the use of fast field codecs for multivalued fast field #1093

Closed
fmassot opened this issue Jun 22, 2021 · 0 comments
Closed

Unlock the use of fast field codecs for multivalued fast field #1093

fmassot opened this issue Jun 22, 2021 · 0 comments
Assignees
@PSeitz

Comments

@fmassot
Copy link
Contributor

fmassot commented Jun 22, 2021

Currently, we can use 3 different codecs for single value fast field: Bitpacked, LinearInterpol and MultiLinearInterpol.

But this is not the case for MultiValuedFastFieldReader where the only available codec for the data is BitpackedFastFieldReader , see code.

The request is thus to replace the harcoded BitpackedFastFieldReader by the enum DynamicFastFieldReader for the MultiValuedFastFieldReader.
PSeitz added a commit to PSeitz/tantivy that referenced this issue Jun 23, 2021
@PSeitz
Use dynamic fastfield codes for multivalues fixes quickwit-oss#1093
b50d763 
Use dynamic fastfield codes for multivalues fixes (only sorting case covered)
Rename get to get_val due to conflict with Vec
use u64 precision instead of u32 for get_range, to allow use of existing fast field interface interface (actually not sure if it would be better have a different interface)
@PSeitz PSeitz closed this as completed in 6ba302c Jun 30, 2021
PSeitz added a commit that referenced this issue Jun 30, 2021
@PSeitz
Merge pull request #1097 from PSeitz/multifastfield
aea2e77 
Use dynamic fastfield codes for multivalues fixes #1093
This was referenced Feb 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSeitz PSeitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix open bytes index quickwit-oss/tantivy
aggregation PSeitz/tantivy
2 participants
@fmassot @PSeitz