Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to use an injection based API along with the build tool to man… #84

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Change to use an injection based API along with the build tool to man… #84

merged 1 commit into from
Nov 13, 2018

Conversation

stuartwdouglas
Copy link
Member

…age dependencies

kenfinnigan
kenfinnigan suggested changes Nov 13, 2018
View reviewed changes
Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it's good, and has the pieces we all agreed to last week.

Just one minor comment on @Record

core/deployment-api/src/main/java/org/jboss/shamrock/annotations/Record.java Outdated Show resolved Hide resolved
@n1hility n1hility self-requested a review November 13, 2018 21:14
@stuartwdouglas stuartwdouglas merged commit bc5e67e into quarkusio:master Nov 13, 2018
@Sanne Sanne deleted the injection-api branch November 14, 2018 16:15
@cescoffier cescoffier added this to the 0.1.0 milestone Jan 21, 2019
@michael-schnell michael-schnell mentioned this pull request Jan 21, 2020
Closed
@jean-merelis jean-merelis mentioned this pull request Jan 29, 2020
Closed
This was referenced Mar 9, 2020
Closed
Closed
This was referenced Apr 16, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1hility n1hility n1hility approved these changes

@dmlloyd dmlloyd dmlloyd left review comments

@kenfinnigan kenfinnigan kenfinnigan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stuartwdouglas @dmlloyd @n1hility @kenfinnigan @cescoffier