JDBC Opentracing Regression on 1.3.0.CR1 #7695
Comments
|
Hello @bcluap, |
|
cc @gsmet (in case it could be config related) and @pavolloffay |
|
git clone https://github.com/bcluap/quarkus.git Then: Then: If you build with Alpha1 then the error goes away. My environment: paul@PCBLaptop: |
|
It's probably due to the new datasource config. I'll have a look tomorrow. |
|
I just had a closer look at that one. The driver has always been a build time config: you cannot override it at runtime. I don't know how it was working before, I find it surprising, but that's the expected behavior. |
|
Just to be sure: does it work properly if you define the driver at build time? |
|
Yes, but as per my test project, it works fine with Alpha1... very weird.
Is there a performance hit using the tracing driver if tracing is disabled?
I want to be able to turn tracing on/off without rebuilding.
Paul Carter-Brown
Director
Jini Guru
m: +27 (0) 83 442 7179 <+27834427179>
a: 1st Floor, Golf House, Design Quarter, Cnr. William Nicol and Leslie
Johannesburg, South Africa
w: jini.guru e: paul@jini.guru
Disclaimer: This message and/or attachment(s) may contain
privileged, confidential and/or personal information. If you are not the
intended recipient you may not disclose or distribute any of
the information contained within this message. In such case you must
destroy this message and inform the sender of the error. Jini Guru may not
accept liability for any errors, omissions, information and viruses
contained in the transmission of this message. Any opinions, conclusions
and other information contained within this message not related to Jini
Guru official business is deemed to be that of the individual only and is
not endorsed by Jini Guru.
…On Tue, Mar 10, 2020 at 1:06 PM Guillaume Smet ***@***.***> wrote:
Just to be sure: does it work properly if you define the driver at build
time?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7695?email_source=notifications&email_token=AGMB23NOZA63HW7UAPESUNTRGYNLHA5CNFSM4LEIED42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOK7BXQ#issuecomment-597029086>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMB23MNFOZSZDR3ZYHIF4LRGYNLHANCNFSM4LEIED4Q>
.
|
|
@bcluap can we close this issue ?
There should be a small performance hit as spans will be created (but span creation should be cheap), with OpenTracing disabled the tracer implementation is a No-op tracer so there will be no network overhead. |
|
Yes you can close this. Thanks |
Describe the bug
"Unable to acquire JDBC Connection" when turning on JDBC opentracing
Expected behavior
JDBC can connect and tracing events are sent
Actual behavior
Errors are thrown and JPA fails completely:
: javax.persistence.PersistenceException: org.hibernate.exception.GenericJDBCException: Unable to acquire JDBC Connection
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:154)
at org.hibernate.query.internal.AbstractProducedQuery.list(AbstractProducedQuery.java:1539)
at org.hibernate.query.Query.getResultList(Query.java:165)
at guru.jini.arch.impl.persistence.WrappedQuery.getResultList(WrappedQuery.java:93)
at guru.jini.arch.impl.persistence.WrappedQuery.getResultList(WrappedQuery.java:84)
at guru.jini.arch.impl.persistence.JpaImpl.getResultList(JpaImpl.java:488)
at guru.jini.arch.impl.persistence.JpaImpl.getResultList(JpaImpl.java:324)
at guru.jini.arch.impl.persistence.JpaImpl_ClientProxy.getResultList(JpaImpl_ClientProxy.zig:487)
at guru.jini.services.wallet.dao.Dao.getAllRateConfigs(Dao.java:496)
at guru.jini.services.wallet.rating.impl.bestprefix.BestPrefixRatingEngine.refresh(BestPrefixRatingEngine.java:196)
at guru.jini.services.wallet.rating.impl.bestprefix.BestPrefixRatingEngine.lambda$init$0(BestPrefixRatingEngine.java:60)
at guru.jini.arch.impl.thread.NamedRunnable.run(NamedRunnable.java:40)
at guru.jini.arch.impl.thread.WrappedScheduledFuture.lambda$new$2(WrappedScheduledFuture.java:82)
at guru.jini.arch.impl.thread.NamedRunnable.run(NamedRunnable.java:40)
at guru.jini.arch.impl.thread.RequestContextActivator.runInRequestContext(RequestContextActivator.java:52)
at guru.jini.arch.impl.thread.RequestContextActivator_Subclass.runInRequestContext$$superaccessor323(RequestContextActivator_Subclass.zig:24)
at guru.jini.arch.impl.thread.RequestContextActivator_Subclass$$function$$323.apply(RequestContextActivator_Subclass$$function$$323.zig:41)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54)
at io.quarkus.arc.impl.ActivateRequestContextInterceptor.aroundInvoke(ActivateRequestContextInterceptor.java:24)
at io.quarkus.arc.impl.ActivateRequestContextInterceptor_Bean.intercept(ActivateRequestContextInterceptor_Bean.zig:65)
at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:41)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
at guru.jini.arch.impl.thread.RequestContextActivator_Subclass.runInRequestContext(RequestContextActivator_Subclass.zig:330)
at guru.jini.arch.impl.thread.RequestContextActivator_ClientProxy.runInRequestContext(RequestContextActivator_ClientProxy.zig:232)
at guru.jini.arch.impl.thread.WrappedExecutorService.lambda$surroundWithRequestScoped$0(WrappedExecutorService.java:143)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.hibernate.exception.GenericJDBCException: Unable to acquire JDBC Connection
at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:47)
at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113)
at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:99)
at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.acquireConnectionIfNeeded(LogicalConnectionManagedImpl.java:107)
at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.getPhysicalConnection(LogicalConnectionManagedImpl.java:134)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl.connection(StatementPreparerImpl.java:50)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl$5.doPrepare(StatementPreparerImpl.java:149)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl$StatementPreparationTemplate.prepareStatement(StatementPreparerImpl.java:176)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl.prepareQueryStatement(StatementPreparerImpl.java:151)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:2104)
at org.hibernate.loader.Loader.executeQueryStatement(Loader.java:2034)
at org.hibernate.loader.Loader.executeQueryStatement(Loader.java:2012)
at org.hibernate.loader.Loader.doQuery(Loader.java:953)
at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:354)
at org.hibernate.loader.Loader.doList(Loader.java:2838)
at org.hibernate.loader.Loader.doList(Loader.java:2820)
at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2652)
at org.hibernate.loader.Loader.list(Loader.java:2647)
at org.hibernate.loader.custom.CustomLoader.list(CustomLoader.java:338)
at org.hibernate.internal.SessionImpl.listCustomQuery(SessionImpl.java:2131)
at org.hibernate.internal.AbstractSharedSessionContract.list(AbstractSharedSessionContract.java:1163)
at org.hibernate.query.internal.NativeQueryImpl.doList(NativeQueryImpl.java:173)
at org.hibernate.query.internal.AbstractProducedQuery.list(AbstractProducedQuery.java:1530)
... 30 more
Caused by: java.sql.SQLException: Driver does not support the provided URL: jdbc:tracing:mysql://localhost/jg_services
at io.agroal.pool.ConnectionFactory.connectionSetup(ConnectionFactory.java:215)
at io.agroal.pool.ConnectionFactory.createConnection(ConnectionFactory.java:200)
at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:390)
at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:372)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at io.agroal.pool.util.PriorityScheduledExecutor.beforeExecute(PriorityScheduledExecutor.java:65)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1126)
... 2 more
To Reproduce
Steps to reproduce the behavior:
-Dquarkus.datasource.url=jdbc:tracing:mysql://localhost/xxx
-Dquarkus.datasource.driver=io.opentracing.contrib.jdbc.TracingDriver
Configuration
# Add your application.properties here, if applicable.Screenshots
(If applicable, add screenshots to help explain your problem.)
Environment (please complete the following information):
Quarkus 1.3.0.CR1
Additional context
Exact same app built with 1.3.0.Alpha1 works fine. Changing the version to CR1 causes the error
The text was updated successfully, but these errors were encountered: