-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace oidc auth apple screenshots with generic ones #45094
Replace oidc auth apple screenshots with generic ones #45094
Conversation
Hi @sberyozkin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rghara, please follow with the X updates and then we will get the issue resolved, thanks
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
Sorry @sberyozkin I am not sure if I understand what you mean with the X updates. I already changed the PR to have only one commit. Was that your ask? Or is it a different thing? |
Status for workflow
|
@rghara My apologies, I meant that after this PR is merged, one more will be needed to actually fix the linked issue, to update X ( formely Twitter) images. Why did you merge the main branch though into this PR, please don't do it, if you need to sync up the PR with the main branch, you need to rebase, we updated the Contribution guide to explain how to do it, but you don't really need to rebase these PRs either. Now this PR has become invalid, please recreate it with the original single commit, I can do if you'd like |
I got confused. Now it is clear. I'll redo the PR. |
Replace oidc auth apple screenshots with generic ones
Related to #42549