Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace oidc auth apple screenshots with generic ones #45094

Conversation

rghara
Copy link
Contributor

@rghara rghara commented Dec 12, 2024

Replace oidc auth apple screenshots with generic ones

Related to #42549

@rghara
Copy link
Contributor Author

rghara commented Dec 12, 2024

Hi @sberyozkin,
PR request raised.

@sberyozkin sberyozkin self-requested a review December 12, 2024 17:49
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rghara, please follow with the X updates and then we will get the issue resolved, thanks

Copy link

github-actions bot commented Dec 12, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@rghara
Copy link
Contributor Author

rghara commented Dec 12, 2024

Thanks @rghara, please follow with the X updates and then we will get the issue resolved, thanks

Sorry @sberyozkin I am not sure if I understand what you mean with the X updates. I already changed the PR to have only one commit. Was that your ask? Or is it a different thing?

Copy link

quarkus-bot bot commented Dec 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 534f24d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

sberyozkin commented Dec 12, 2024

@rghara My apologies, I meant that after this PR is merged, one more will be needed to actually fix the linked issue, to update X ( formely Twitter) images.

Why did you merge the main branch though into this PR, please don't do it, if you need to sync up the PR with the main branch, you need to rebase, we updated the Contribution guide to explain how to do it, but you don't really need to rebase these PRs either.

Now this PR has become invalid, please recreate it with the original single commit, I can do if you'd like

@sberyozkin
Copy link
Member

@rghara See #45116, thanks

@sberyozkin sberyozkin closed this Dec 13, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 13, 2024
@rghara
Copy link
Contributor Author

rghara commented Dec 13, 2024

@rghara My apologies, I meant that after this PR is merged, one more will be needed to actually fix the linked issue, to update X ( formely Twitter) images.

Why did you merge the main branch though into this PR, please don't do it, if you need to sync up the PR with the main branch, you need to rebase, we updated the Contribution guide to explain how to do it, but you don't really need to rebase these PRs either.

Now this PR has become invalid, please recreate it with the original single commit, I can do if you'd like

@sberyozkin

I got confused. Now it is clear. I'll redo the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants