Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Renarde in https://quarkus.io/guides/security-openid-connect-providers #42549

Open
sberyozkin opened this issue Aug 14, 2024 · 5 comments
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/security good first issue Good for newcomers kind/bug Something isn't working

Comments

@sberyozkin
Copy link
Member

Description

The https://quarkus.io/guides/security-openid-connect-providers doc is about showing with some sample images, the typical process for registering an application with a given provider.

Originally, I copied a few of those images from Renarde docs. It can be causing the confusion that this is indeed how Renarde applications must be registered.

So this issue is about replacing images referencing Renarde with more neutral images

CC @Sanne

Implementation ideas

No response

@sberyozkin sberyozkin added kind/bug Something isn't working good first issue Good for newcomers area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Aug 14, 2024
@Sanne
Copy link
Member

Sanne commented Aug 14, 2024

+1 but let's make sure people can find instructions. I had hit this guide when googling for it.. the Renarde guides don't seem to be found as easily. Might need to improve the indexing of the Renarde guides.

@sberyozkin
Copy link
Member Author

Sure, a link to https://docs.quarkiverse.io/quarkus-renarde/dev/security.html#oidc should be added in References

@gsmet
Copy link
Member

gsmet commented Aug 14, 2024

No problem adding a link but let’s make sure the quarkus.io version is comprehensive and the reference for vanilla Quarkus.

@rghara
Copy link
Contributor

rghara commented Oct 15, 2024

@sberyozkin @Sanne @gsmet

Hi all - I was thinking of working on this issue as part of the Hacktoberfest 2024. I took some screenshots for the GitHub provider for an example to ask you if that is what you mean with more neutral images. Please let me know if I am on the right track.

Also, I was wondering if you are okay if I replaced the images for each provider gradually through a separate pull request.

Image

Image

Image

Image

@rghara
Copy link
Contributor

rghara commented Oct 21, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/security good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants