Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CertificateGenerator in OIDC Wiremock tests #44808

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

sberyozkin
Copy link
Member

Fixes #44761

Thanks @cescoffier for thinking about supporting creating chains, it was very easy for me to reuse the code.
I ended up using KeyStore API directly to insert certificate entries, as it is the only material that has to be inserted, but i did not hesitate to borrow the working code block for it from CaGenerator :-).

Copy link

quarkus-bot bot commented Nov 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ebb2c0c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member

gsmet commented Nov 28, 2024

Were these tests in 3.15?

@sberyozkin
Copy link
Member Author

@gsmet Yes, I'm not sure now how it will backport but I'll prepare a 3.15 specific backport, ping me please if it won't backport automatically

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By the way, any API improvement ideas for the generator are more than welcome. I don't use that part often, so finding the best usability pattern is hard.

@sberyozkin
Copy link
Member Author

Thanks @cescoffier Sure, I'll try to remove the direct use of KeyStore API, may take some time but I'm on it

@sberyozkin sberyozkin merged commit 2d19846 into quarkusio:main Dec 1, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 1, 2024
@sberyozkin sberyozkin deleted the fix_oidc_wiremock_tests branch December 1, 2024 12:53
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.3 Dec 3, 2024
@gsmet gsmet modified the milestones: 3.17.3, 3.15.3 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable OIDC wiremock tests once a new certificate chain is available
3 participants