-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable OIDC wiremock tests once a new certificate chain is available #44761
Comments
/cc @pedroigor (oidc) |
Hi @gsmet
Unfortunately, I'm not sure we have a tooling support yet, it is nearly there, @cescoffier has https://github.com/cescoffier/certificate-generator (thanks @gastaldi for sharing the link), which is very good, but the impacted OIDC tests:
Clement, is that already possible with your cert generator ? If not, I can regenerate them manually and make them last long enough not to be worried about the expiry for a few years, and get rid of the certificate resources later, once it becomes possible. |
You can use the API to do that. Check in the code repository there is an example. |
@cescoffier Looking very good |
@cescoffier Sorry, missed your message, yeah, I successfully copied it :-) |
Description
In #44760, I had to disable a good number of OIDC wiremock tests because they now use expired certificates.
The question is how to re-create the certificates. The difficulty is, it is a full chain, with the leaf, intermediate and root certificates - I think Clement @cescoffier made it possible to auto-generate such 3-certificate chains.
But one of the tests has a truststore p12 file which has the leaf certificate from this chain imported - to test a case where a token is signed with this leaf certificate and with the whole chain being inlined in the token - to verify such a leaf cert is trusted by the server.
Clement, can your certificate extension do some magic such that a 3 cert chain is generated and the leaf cert is also inserted into a truststore ?
I may have to just regenerate the whole chain manually...
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: