[3.2] Direct patch for the Data source and Logging guide #37394
Conversation
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
docs/src/main/asciidoc/logging.adoc
Outdated
| @@ -9,7 +9,7 @@ include::_attributes.adoc[] | |||
| :categories: core,getting-started,observability | |||
| :diataxis-type: reference | |||
|
|
|||
| Read about the use of logging API in Quarkus, configuring logging output, and using logging adapters to unify the output from other logging APIs. | |||
| Read about the use of the JBoss Logging API in Quarkus, configuring logging output, and using logging adapters to unify the output from other logging APIs. | |||
There was a problem hiding this comment.
A few lines below we mention that developers can use one of many APIs... so I don't think this change makes sense
There was a problem hiding this comment.
Feel free to merge though, I'm not blocking the PR.
There was a problem hiding this comment.
Ok. Good point. I will patch it like this:
Read about the use of logging APIs in Quarkus, configuring logging output, and using logging adapters for unified output.
Thank you, @yrodiere
Cheers!
There was a problem hiding this comment.
I'm the one who suggested this edit, and I felt it was fine because other logging APIs are mentioned further in the sentence. But the fix seems good too.
Signed-off-by: Michal Maléř <mmaler@redhat.com>
5fca918 to
9b680a4
Compare
|
🙈 The PR is closed and the preview is expired. |
Removing the
in Quarkuspart from theData sourceguide. Asked some SMEs, it is not needed there.Then, I tweaked slightly the Data source and Logging guide abstracts so that we can perform some RHBQ name postprocesing and they contain the proper grammar and information.