Skip to content

Commit

Permalink
Datasource and Logging review for 3.2
Browse files Browse the repository at this point in the history 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
  • Loading branch information
@MichalMaler
MichalMaler committed Nov 29, 2023
1 parent 1e97346 commit 9b680a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/src/main/asciidoc/datasource.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ and pull requests should be submitted there:
https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc
////
[id="datasources"]
= Configure data sources in Quarkus
= Configure data sources
include::_attributes.adoc[]
:diataxis-type: reference
:categories: data,getting-started,reactive
:topics: data,database,datasource,sql,jdbc,reactive

Check warning on line 11 in docs/src/main/asciidoc/datasource.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Spelling] Use correct American English spelling. Did you really mean 'datasource'?

Raw Output:
{"message": "[Quarkus.Spelling] Use correct American English spelling. Did you really mean 'datasource'?", "location": {"path": "docs/src/main/asciidoc/datasource.adoc", "range": {"start": {"line": 11, "column": 24}}}, "severity": "WARNING"}
:extensions: io.quarkus:quarkus-agroal,io.quarkus:quarkus-reactive-mysql-client,io.quarkus:quarkus-reactive-oracle-client,io.quarkus:quarkus-reactive-pg-client,io.quarkus:quarkus-reactive-db2-client,io.quarkus:quarkus-reactive-pg-client,io.quarkus:quarkus-reactive-mssql-client,io.quarkus:quarkus-jdbc-db2,io.quarkus:quarkus-jdbc-derby,io.quarkus:quarkus-jdbc-h2,io.quarkus:quarkus-jdbc-mariadb,io.quarkus:quarkus-jdbc-mssql,io.quarkus:quarkus-jdbc-mysql,io.quarkus:quarkus-jdbc-oracle,io.quarkus:quarkus-jdbc-postgresql

Use a unified configuration model to define data sources for Java Database Connectivity (JDBC) and Reactive drivers.
Use a unified configuration model to define data sources for Java Database Connectivity (JDBC) and Reactive drivers in Quarkus.

////
Note for contributors and writers:
Expand Down Expand Up @@ -593,7 +593,7 @@ hostDescription:: `<host>[:<portnumber>] or address=(host=<host>)[(port=<portnum

Example:: `jdbc:mysql://localhost:3306/test`

For more information, see the link:https://dev.mysql.com/doc/connector-j/en/[official documentation].
For more information, see the link:https://dev.mysql.com/doc/connector-j/en/connector-j-reference-jdbc-url-format.html[official documentation].

===== MySQL limitations

Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/logging.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include::_attributes.adoc[]
:categories: core,getting-started,observability
:diataxis-type: reference

Read about the use of logging API in Quarkus, configuring logging output, and using logging adapters to unify the output from other logging APIs.
Read about the use of logging APIs in Quarkus, configuring logging output, and using logging adapters for unified output.

Quarkus uses the JBoss Log Manager logging backend for publishing application and framework logs.

Check warning on line 14 in docs/src/main/asciidoc/logging.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.

Raw Output:
{"message": "[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.", "location": {"path": "docs/src/main/asciidoc/logging.adoc", "range": {"start": {"line": 14, "column": 18}}}, "severity": "INFO"}
Quarkus supports the JBoss Logging API and multiple other logging APIs, seamlessly integrated with JBoss Log Manager.

Check warning on line 15 in docs/src/main/asciidoc/logging.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.

Raw Output:
{"message": "[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.", "location": {"path": "docs/src/main/asciidoc/logging.adoc", "range": {"start": {"line": 15, "column": 22}}}, "severity": "INFO"}

Check warning on line 15 in docs/src/main/asciidoc/logging.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.

Raw Output:
{"message": "[Quarkus.CaseSensitiveTerms] Use 'JBoss EAP' rather than 'JBoss'.", "location": {"path": "docs/src/main/asciidoc/logging.adoc", "range": {"start": {"line": 15, "column": 100}}}, "severity": "INFO"}
Expand Down

0 comments on commit 9b680a4

Please sign in to comment.